Extend flake8 and address some issues #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And disable some of them. The parser files have a pattern of extra code without 2 blank lines following the classes so we disable that warning for the file. There is still room to expand this to the test folder and the documentation if desired.
It seems that '# flake: noqa' disables everything for the file even if include specific codes to disable and expect the rest to apply. This seems more successful at just disabling particular codes. Oddly not documented (that I could find) but covered here: https://stackoverflow.com/a/54454433/98555
arwedus
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and extend the number of files (only a little) that flake8 checks.